----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74997/#review226472 -----------------------------------------------------------
Ship it! made some local formatting only edits src/slave/containerizer/mesos/isolators/cgroups2/controllers/perf_event.cpp Lines 65 (patched) <https://reviews.apache.org/r/74997/#comment314673> nit: replace .get() with a `*` on the option, similar to a pointer de-reference it's also shorter and makes this line fit within 80 characters without the wrapping :) src/slave/containerizer/mesos/isolators/cgroups2/controllers/perf_event.cpp Lines 89 (patched) <https://reviews.apache.org/r/74997/#comment314674> nit: double newline between top level definitions in a file - Benjamin Mahler On May 17, 2024, 6:01 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74997/ > ----------------------------------------------------------- > > (Updated May 17, 2024, 6:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces the controller process for perf event which > was also present in cgroups1. The controller is > automatically enabled, and should not be visible inside > the cgroups.controllers file in the root cgroup. > > As a consequence, we will not be able to manually > enable or disable this controller via writing to > the cgroup.subtree_control file. > > Reference: > perf_event section in https://docs.kernel.org/admin-guide/cgroup-v2.html > slide 34 in > https://man7.org/conf/ndctechtown2021/cgroups-v2-part-1-intro-NDC-TechTown-2021-Kerrisk.pdf > > > Diffs > ----- > > src/CMakeLists.txt 963d4201afeec0b5b4cdcd5b4bfbbddf466b22c7 > src/Makefile.am 779b893fca3fa2cfe28be1bb9571a44383579ede > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 76c8df9b10ff8142c89a812f24acb8c6accc0ae5 > src/slave/containerizer/mesos/isolators/cgroups2/constants.hpp > 1fb713837b53180fa97d7bbe58ee8f6e638e75fc > src/slave/containerizer/mesos/isolators/cgroups2/controllers/perf_event.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups2/controllers/perf_event.cpp > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74997/diff/2/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
