----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74998/#review226473 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Line 217 (original), 218 (patched) <https://reviews.apache.org/r/74998/#comment314676> "event" typo src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Line 220 (original), 222 (patched) <https://reviews.apache.org/r/74998/#comment314678> nit: double newline? src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 223 (patched) <https://reviews.apache.org/r/74998/#comment314675> nit: whitespace here and below src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 235 (patched) <https://reviews.apache.org/r/74998/#comment314677> nit: keep open and close quotes on the same line src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 241 (patched) <https://reviews.apache.org/r/74998/#comment314679> nit: double newline? - Benjamin Mahler On May 17, 2024, 10:01 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74998/ > ----------------------------------------------------------- > > (Updated May 17, 2024, 10:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > In Cgroups2IsolatorProcess::prepare, it may manually enable controller > by writing to the cgroup.subtree_control process. > > For perf_event, since is is automatically turned on, it does not appear > inside the cgroup.controllers file and hence cannot be written to the > cgroup.subtree_control file. For this reason, we skip the enable call for > the perf_event controller. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 76c8df9b10ff8142c89a812f24acb8c6accc0ae5 > > > Diff: https://reviews.apache.org/r/74998/diff/2/ > > > Testing > ------- > > CgroupsIsolatorTest ROOT_CGROUPS_PERF_Sample passes on both CentOS 7 machine > with cgroups v1 and CentOS 9 machine with cgroups v2 > > > Thanks, > > Jason Zhou > >
