----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75021/#review226494 -----------------------------------------------------------
Fix it, then Ship it! I'll make these edits and commit shortly. configure.ac Lines 399-404 (original), 399-404 (patched) <https://reviews.apache.org/r/75021/#comment314687> remove this entirely now src/slave/containerizer/mesos/linux_launcher.cpp Line 525 (original), 519-525 (patched) <https://reviews.apache.org/r/75021/#comment314688> not needed since we know this is supposed to be the v2 case at this point src/slave/containerizer/mesos/linux_launcher.cpp Line 779 (original), 776-782 (patched) <https://reviews.apache.org/r/75021/#comment314689> ditto here src/tests/containerizer/cgroups_isolator_tests.cpp Lines 383-384 (original), 383-384 (patched) <https://reviews.apache.org/r/75021/#comment314691> ditto on indentation here src/tests/containerizer/cgroups_isolator_tests.cpp Lines 390-391 (original), 390-391 (patched) <https://reviews.apache.org/r/75021/#comment314690> nit: preserve the indentation here (4 space wrap) - Benjamin Mahler On May 29, 2024, 10:37 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75021/ > ----------------------------------------------------------- > > (Updated May 29, 2024, 10:37 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This commit removes the sections where ENABLE_CGROUPS_V2 is used > to determine the compiled code. Any need to determine whether or not > cgroups2 is used will be satisfied using the cgroups2::mounted() function. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 88f3353bbe642127e3be8cecb97d288d9a13b59d > configure.ac e0314fb42e7622c62aa30104c9c0c55ad61fd867 > src/CMakeLists.txt 3973737f1f0719be98350b25abddcba81716207b > src/Makefile.am 68a93674f867ca092ee035ea367f35f4580b073f > src/slave/containerizer/mesos/containerizer.cpp > 2fc1ee56e923b4e6005d17b95dfeff1ec805e9bf > src/slave/containerizer/mesos/linux_launcher.cpp > 7682a561ae26a8b915f58b54a6fbbfb217630394 > src/slave/flags.cpp 1518756618cd76f691c05a88970c236b380a47ae > src/slave/main.cpp 8a0e161ff776f8d0e2e07ec80c931a97374ebe3a > src/tests/CMakeLists.txt 79f42bd892d8aef848ffdf320cb3fbbb5d4fef9c > src/tests/containerizer/cgroups_isolator_tests.cpp > 6a044340418246f63720558a9f77f4058e5c9eb8 > src/tests/containerizer/memory_isolator_tests.cpp > be8475f515b2a51917c0c4e9e6141c68c74b205c > src/tests/environment.cpp 7a55774d82e227f59f5a64180f7a099680d6e5ac > src/tests/mesos.cpp d33c7b4774e3ace4693abded5cac8964d3e30c18 > > > Diff: https://reviews.apache.org/r/75021/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
