----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75046/#review226538 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On June 12, 2024, 12:46 a.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75046/ > ----------------------------------------------------------- > > (Updated June 12, 2024, 12:46 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Previously, when grabbing the destination, we would filter out the default > address at 0.0.0.0/0 by checking that the dst pointer is pointing at an empty > struct. > With newer operating systems, it seems to be possible that the dst pointer > can be pointing at a valid struct that corresponds to 0.0.0.0/0. > To ensure that we are able accurately filter out the default route, we switch > to the libnl function nl_addr_iszero to determine if the nl_addr struct > corresponds to 0.0.0.0/0. > We also apply this change to other areas where nl_addr_get_len to ensure that > non-empty nl_addr with only zeroes are accounted for. > > > Diffs > ----- > > src/linux/routing/diagnosis/diagnosis.cpp > eed84533c9c696c38c0dda850ec47a9f51d81ddb > src/linux/routing/route.cpp bdf29a9c7090fc9483cd89e68afaa694ef271f57 > > > Diff: https://reviews.apache.org/r/75046/diff/2/ > > > Testing > ------- > > Ran PortMappingIsolatorTest on CentOS 9 with libnl 3.7, 3.9 > Ran PortMappingIsolatorTest on CentOS 7 with libnl 3.5 > > > Thanks, > > Jason Zhou > >
