----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75057/#review226570 -----------------------------------------------------------
src/linux/routing/link/link.cpp Lines 279-281 (patched) <https://reviews.apache.org/r/75057/#comment314831> let's also output the link name and the initial two mac addresses here src/linux/routing/link/link.cpp Lines 283-286 (patched) <https://reviews.apache.org/r/75057/#comment314834> let's document more here on all the scenarios that we've observed including the original mismatch that can happen when the veth pair is created, ditto for the commit message src/linux/routing/link/link.cpp Lines 287-289 (patched) <https://reviews.apache.org/r/75057/#comment314833> nit: can this fit on fewer lines? src/linux/routing/link/link.cpp Lines 292-293 (patched) <https://reviews.apache.org/r/75057/#comment314832> ditto here, can we include the link name, the two mac addresses, and the target mac address? - Benjamin Mahler On June 18, 2024, 8:51 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75057/ > ----------------------------------------------------------- > > (Updated June 18, 2024, 8:51 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > It seems that there are scenarios where mesos containers cannot communicate > with agents as the MAC addresses are set incorrectly, leading to dropped > packets. A workaround for this behavior is to check that the MAC address is > set correctly after the ioctl call, and retry the address setting if > necessary. > > > Diffs > ----- > > src/linux/routing/link/link.cpp bff172dea63f77a2c7bafd7e3fbee5dca1dfbd51 > > > Diff: https://reviews.apache.org/r/75057/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
