----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75088/#review226679 -----------------------------------------------------------
configure.ac Line 2314 (original), 2314 (patched) <https://reviews.apache.org/r/75088/#comment314944> Forced to check these separately because when checking the zlib functions together, the generated code is wrong: ` | | namespace conftest { | extern "C" int deflate, gzread, gzwrite, inflate (); | } | int | main (void) | { | return conftest::deflate, gzread, gzwrite, inflate (); | ; | return 0; | } ` which gives the error: `conftest.cpp:49:27: error: 'gzread' was not declared in this scope; did you mean 'conftest::gzread'? 49 | return conftest::deflate, gzread, gzwrite, inflate (); | ^~~~~~ | conftest::gzread conftest.cpp:44:27: note: 'conftest::gzread' declared here 44 | extern "C" int deflate, gzread, gzwrite, inflate (); | ^~~~~~ conftest.cpp:49:35: error: 'gzwrite' was not declared in this scope; did you mean 'conftest::gzwrite'? 49 | return conftest::deflate, gzread, gzwrite, inflate (); | ^~~~~~~ | conftest::gzwrite conftest.cpp:44:35: note: 'conftest::gzwrite' declared here 44 | extern "C" int deflate, gzread, gzwrite, inflate (); | ^~~~~~~ conftest.cpp:49:44: error: 'inflate' was not declared in this scope; did you mean 'conftest::inflate'? 49 | return conftest::deflate, gzread, gzwrite, inflate (); | ^~~~~~~ | conftest::inflate conftest.cpp:44:44: note: 'conftest::inflate' declared here 44 | extern "C" int deflate, gzread, gzwrite, inflate (); | ` Since this is generated code by autotools, we can't directly modify the code to have the required namespace. - Jason Zhou On July 15, 2024, 3:46 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75088/ > ----------------------------------------------------------- > > (Updated July 15, 2024, 3:46 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > For in review #75080, we made use of replace_bpf_fd and BPF_F_REPLACE > which were added in kernel 5.6. Our current ubuntu 20.04 base image > uses kernel 5.4. > > As such we will be upgrading the ubuntu version used > in Jenkins to 22.04, whose base image uses kernel 5.15, so that we can > make mesos on the updated pipeline, enabling reviewbot, tidybot, and > coverity. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 10e609d8a056fa0efe25b1d3a49912d1893f6029 > configure.ac 7c0597f56a11cbaf6874aba2e910cb36debd20a7 > support/docker-build.sh cb0b05b6effef246a88efedd5dd5f4cd15231397 > support/jenkins/reviewbot.sh 03ebcd6007d6da9bfb5ef0d2b3f84b1f83219127 > support/mesos-build/ubuntu-20.04-arm.dockerfile > a3b321fb740a5b0a0add12f31511ed2ff6b03691 > support/mesos-build/ubuntu-20.04.dockerfile > e183ff742b034009f814372998a596899a3e3b7b > support/mesos-tidy/Dockerfile 769a22d9e0dde4cf6518ad5900c5b316c48d925c > support/verify-reviews.py 8e7c54faae0f728ef2138995c86a4a4ef4b5df47 > > > Diff: https://reviews.apache.org/r/75088/diff/1/ > > > Testing > ------- > > Tested build with 22.04 base image using both cmake and autotools, builds > were able to complete. > Tested using docker-build, build was able to complete. > Mesos-tidy will need to be tested on jenkins but I expect it should also > complete as we can now build on 22.04 > > > Thanks, > > Jason Zhou > >
