-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75090/
-----------------------------------------------------------
(Updated July 15, 2024, 9:21 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Address review feedback
Bugs: MESOS-10243
https://issues.apache.org/jira/browse/MESOS-10243
Repository: mesos
Description (updated)
-------
This addresses the previous todo where we want to set the MAC address
of the peer link when we are creating a veth pair so that we can avoid
the race condition we are racing against udev to see who will set the
MAC address of the interface last.
see: https://reviews.apache.org/r/75087/
Diffs (updated)
-----
src/linux/routing/link/veth.hpp 1e54ce696bf219fd83874efb88a7de2e245fe048
src/linux/routing/link/veth.cpp 36aad5fec719e40cb5377ef80ab2c4b54ef66496
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
894d77c5680f5ea4e9c2b54a41e05a6d1aaf10f2
src/tests/containerizer/routing_tests.cpp
b18f741e0ef673e275666a4a7a054bd96297590e
Diff: https://reviews.apache.org/r/75090/diff/2/
Changes: https://reviews.apache.org/r/75090/diff/1-2/
Testing
-------
Added test to check that veth::create with a target MAC address is able to
create a link with that target MAC address, and that we are also able to set
the MAC address of the peer link in the in veth::create.
RoutingVethTest and PortMappingIsolatorTest pass (except
ROOT_ContainerARPExternal which has always failed)
Thanks,
Jason Zhou
