----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75096/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- Currently, the Entry class does not have readable helper functions for determining whether the device accesses represented by one Entry would be a subset of that of another. In addition, we want more readable ways to determine if a device has wildcards present and if it has any accesses specified. These additions will streamline the logic in the DeviceManager DeviceManager, which will heavily utilize the Entry class, improving code readability. Diffs ----- src/linux/cgroups.hpp eaa4cdf9fd0fe6dd848a6626c4c42ccab070e232 src/linux/cgroups.cpp c4289493315eb4765192f90099c5b632c6d7f9d1 src/tests/containerizer/cgroups_tests.cpp 0f4967ff1754fcf54e9363e2bc62c7bc44ac4a56 Diff: https://reviews.apache.org/r/75096/diff/1/ Testing ------- Tests added for `is_improper_subset_of`, tests passed. Thanks, Jason Zhou
