----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75102/#review226712 -----------------------------------------------------------
Ship it! * The TODO in the header needs an update now? src/slave/containerizer/device_manager/device_manager.cpp Lines 163 (patched) <https://reviews.apache.org/r/75102/#comment314993> this looks like a const function in terms of not mutating internal state of this class? - Benjamin Mahler On July 23, 2024, 8:54 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75102/ > ----------------------------------------------------------- > > (Updated July 23, 2024, 8:54 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, the device manager only keeps track of the state in memory, > and does not commit the changes by attaching an ebpf file to the > corresponding cgroup. We will now generate and attach the ebpf file > when configure and reconfigure are called. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.cpp > a392000ea08c997364e8d59429e0f3a24aa67b39 > src/tests/device_manager_tests.cpp 398846bdd66fa2c78827fb8e25f1312545cc65a2 > > > Diff: https://reviews.apache.org/r/75102/diff/1/ > > > Testing > ------- > > Added extra testing steps on top of `configure` and `reconfigure` tests to > ebpf program behavior via actual device accesses. Unit tests for > DeviceManager pass > > > Thanks, > > Jason Zhou > >
