----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75107/#review226714 -----------------------------------------------------------
Ship it! - Benjamin Mahler On July 24, 2024, 6:26 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75107/ > ----------------------------------------------------------- > > (Updated July 24, 2024, 6:26 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, we have to directly compare member variables to see if one > Access object would overlap that of another, which isn't very clear > to people that would be reading the code. > > We add a helper to abstract away the logic to see if the accesses > specified in one Access instance would overlap with that of another > > > Diffs > ----- > > src/linux/cgroups.hpp 4fefb5c3b34c539197967afff0b0b533f47852c8 > src/linux/cgroups.cpp 3dae320bd54e81175ff5acaa007f4c6805d6cb4c > src/tests/containerizer/cgroups_tests.cpp > e4ca7933ba692aacf3cdba0c4a6c1411c1a47604 > > > Diff: https://reviews.apache.org/r/75107/diff/1/ > > > Testing > ------- > > Unit tests added, tests pass > > > Thanks, > > Jason Zhou > >
