----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75109/#review226719 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 25, 2024, 11:48 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75109/ > ----------------------------------------------------------- > > (Updated July 25, 2024, 11:48 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, the deny block matches a device access iff all accesses > match on the deny block. For example, a rw access would not match the > deny block even if the deny block had w access specified. > > We would expect that the deny block should deny all accesses if the > type, major, and minor number matches, and if any of the device accesses > overlap with what's specified in the deny block. > > > Diffs > ----- > > src/linux/cgroups2.cpp cb3c425a46f33f5434f870c03dd7de5be3331ece > src/tests/containerizer/cgroups2_tests.cpp > c73045632f1bc102d42852b9095a4fe6e11839bb > > > Diff: https://reviews.apache.org/r/75109/diff/3/ > > > Testing > ------- > > Added test case to test new deny block behavior. Tests pass > > > Thanks, > > Jason Zhou > >
