----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75117/#review226729 -----------------------------------------------------------
Ship it! Thanks for the quick follow up! src/tests/device_manager_tests.cpp Lines 451 (patched) <https://reviews.apache.org/r/75117/#comment315006> try to avoid mixing style changes in with logical changes, we use to quasi-ban this don't hesitate to make more commits, they are strongly preferred to reduce the cognitive load on the reviewers one tool that will help you here is `git add -p`, it makes incrementally committing much easier! I'll locally split it out on this one for you on landing - Benjamin Mahler On July 26, 2024, 11:33 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75117/ > ----------------------------------------------------------- > > (Updated July 26, 2024, 11:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Changes when merging previous changes caused some DeviceManager > testcases to fail. > > This patch updates the tests to pass it. > > > Diffs > ----- > > src/tests/device_manager_tests.cpp aebf9014c72f09b52d48b58b82c6a4fdd3567765 > > > Diff: https://reviews.apache.org/r/75117/diff/1/ > > > Testing > ------- > > DeviceManager and Cgroups2 tests pass > > > Thanks, > > Jason Zhou > >
