----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75120/#review226749 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 29, 2024, 6:31 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75120/ > ----------------------------------------------------------- > > (Updated July 29, 2024, 6:31 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > When destroy() is called on a container, its cgroup and its children > will be cleaned up. We need to remove the cgroup from the device manager > state when this happens to ensure that the state is accurate. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.hpp > 6d5a7693ba1262168a920861d74c73e25903dd44 > src/slave/containerizer/device_manager/device_manager.cpp > 9c3e6c00cedff5aeb4e3726adb002a29517b254f > src/tests/device_manager_tests.cpp 4f925f3ffd540fed99397013460c61aaab6350ff > > > Diff: https://reviews.apache.org/r/75120/diff/2/ > > > Testing > ------- > > Added test for remove(), tests pass > > > Thanks, > > Jason Zhou > >
