----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75159/#review226803 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 232-259 (original), 234-261 (patched) <https://reviews.apache.org/r/75159/#comment315109> why is core different from perf_event or devices? why can't we call prepare and push it into the controllers? - Benjamin Mahler On Aug. 9, 2024, 3:45 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75159/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2024, 3:45 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently the core controller is skipped over during prepare(), > and it is not added to the container's registered controlelrs. > > We need to register the core controller so that its functions can be > called by the isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > b28ae7f386c03c12889faf901c516132aa3fccc4 > > > Diff: https://reviews.apache.org/r/75159/diff/1/ > > > Testing > ------- > > CgroupsIsolatorTest.ROOT_CGROUPS_PidsAndTids is able to correctly find the > number of processes/threads > > > Thanks, > > Jason Zhou > >
