----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75163/#review226817 -----------------------------------------------------------
src/tests/containerizer/cgroups_isolator_tests.cpp Lines 2790 (patched) <https://reviews.apache.org/r/75163/#comment315118> do I understand correctly that all of the cgroups2::xxx functions support `cgroup` being relative or absolute? src/tests/containerizer/cgroups_isolator_tests.cpp Line 2790 (original), 2792-2801 (patched) <https://reviews.apache.org/r/75163/#comment315117> this seems to be a test that checks that all the subsystems / controllers can be loaded? ``` // This test verifies all the local enabled cgroups subsystems // can be automatically loaded by the cgroup isolator. ``` so don't you want to check that all the various controllers we support are enabled? - Benjamin Mahler On Aug. 12, 2024, 2:44 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75163/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2024, 2:44 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > currently, the ROOT_CGROUPS_AutoLoadSubsystems test is failing because > it is checking for hierarchies for subsystems enabled under > 'cgroups/all'. In cgroups2 we cannot perform this check because of the > unified hierarchy. > > Hence we skip this hierarchy check and instead check that all available > cgroups2 controllers are enabled by reading cgroup.controllers and > cgroup.subtree_control. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f2d6d274146ed1ef8f560fbba0da18051e0f1281 > > > Diff: https://reviews.apache.org/r/75163/diff/1/ > > > Testing > ------- > > CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems passes > > > Thanks, > > Jason Zhou > >
