----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75170/ -----------------------------------------------------------
(Updated Aug. 15, 2024, 8:52 p.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- In cgroups2, the current linux launcher does not create cgroups nor does it move the pids into the container's leaf cgroup during fork(). When we launch a container, we first prepare it via the isolators, then the launcher will call fork to, among other things, move the pid into its appropriate cgroup. Once the fork is over, isolate() is called on the isolators. As such, we will remove the cgroups2 isolator's current behavior of assigning pids into leaf cgroups as it is already done by the linux launcher. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp d1507ecd979405d1fd4d56c5fcd990b22eb311f6 src/slave/containerizer/mesos/linux_launcher.cpp f651afee0de9674da76f97fee93ce2d2573dd289 Diff: https://reviews.apache.org/r/75170/diff/3/ Changes: https://reviews.apache.org/r/75170/diff/2-3/ Testing ------- Compiles okay. When later patches are applied NamespacesIsolatorTest pass and NestedMesosContainerizerTests pass (except for the ones that check for subsystem hierarchies). CgroupsIsolatorTests pass except for the ones that use deprecated subsystems. Thanks, Jason Zhou
