----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75178/#review226859 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 336-343 (patched) <https://reviews.apache.org/r/75178/#comment315146> Since the workload runs in the leaf cgroup, we don't want to change the non-leaf one here. - Benjamin Mahler On Aug. 15, 2024, 8:42 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75178/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2024, 8:42 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > In cgroups1, we chown for nested cgroups so that they can create deeper > layers of cgroups. We want to replicate this behavior in cgroups2. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > d1507ecd979405d1fd4d56c5fcd990b22eb311f6 > > > Diff: https://reviews.apache.org/r/75178/diff/1/ > > > Testing > ------- > > Compiles okay. When later patches are applied NamespacesIsolatorTest pass and > NestedMesosContainerizerTests pass (except for the ones that check for > subsystem hierarchies) > > > Thanks, > > Jason Zhou > >
