cloud-fan commented on a change in pull request #26881: [SPARK-30252][SQL]
Disallow negative scale of Decimal
URL: https://github.com/apache/spark/pull/26881#discussion_r366725192
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala
##########
@@ -63,13 +66,29 @@ class DecimalSuite extends SparkFunSuite with
PrivateMethodTester {
intercept[ArithmeticException](Decimal(1e17.toLong, 17, 0))
}
- test("creating decimals with negative scale") {
- checkDecimal(Decimal(BigDecimal("98765"), 5, -3), "9.9E+4", 5, -3)
- checkDecimal(Decimal(BigDecimal("314.159"), 6, -2), "3E+2", 6, -2)
- checkDecimal(Decimal(BigDecimal(1.579e12), 4, -9), "1.579E+12", 4, -9)
- checkDecimal(Decimal(BigDecimal(1.579e12), 4, -10), "1.58E+12", 4, -10)
- checkDecimal(Decimal(103050709L, 9, -10), "1.03050709E+18", 9, -10)
- checkDecimal(Decimal(1e8.toLong, 10, -10), "1.00000000E+18", 10, -10)
+ test("creating decimals with negative scale under legacy mode") {
+ withSQLConf(SQLConf.LEGACY_ALLOW_NEGATIVE_SCALE_OF_DECIMAL_ENABLED.key ->
"true") {
+ checkDecimal(Decimal(BigDecimal("98765"), 5, -3), "9.9E+4", 5, -3)
+ checkDecimal(Decimal(BigDecimal("314.159"), 6, -2), "3E+2", 6, -2)
+ checkDecimal(Decimal(BigDecimal(1.579e12), 4, -9), "1.579E+12", 4, -9)
+ checkDecimal(Decimal(BigDecimal(1.579e12), 4, -10), "1.58E+12", 4, -10)
+ checkDecimal(Decimal(103050709L, 9, -10), "1.03050709E+18", 9, -10)
+ checkDecimal(Decimal(1e8.toLong, 10, -10), "1.00000000E+18", 10, -10)
+ }
+ }
+
+ test("SPARK-30252: Negative scale is not allowed by default") {
+ withSQLConf(SQLConf.LEGACY_ALLOW_NEGATIVE_SCALE_OF_DECIMAL_ENABLED.key ->
"false") {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
