vanzin commented on a change in pull request #26502: [SPARK-29876][SS] Delete/archive file source completed files in separate thread URL: https://github.com/apache/spark/pull/26502#discussion_r367060788
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala ########## @@ -353,8 +356,34 @@ object FileStreamSource { def size: Int = map.size() } - private[sql] trait FileStreamSourceCleaner { - def clean(entry: FileEntry): Unit + private[sql] abstract class FileStreamSourceCleaner extends Logging { + val numThreads = SQLConf.get.getConf(SQLConf.FILE_SOURCE_CLEANER_NUM_THREADS) Review comment: This is still a field. See my previous comment for how to avoid it being a field. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org