viirya commented on a change in pull request #24938: [SPARK-27946][SQL] Hive
DDL to Spark DDL conversion USING "show create table"
URL: https://github.com/apache/spark/pull/24938#discussion_r373723799
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1017,16 +1067,152 @@ case class ShowCreateTableCommand(table:
TableIdentifier) extends RunnableComman
// TODO: [SPARK-28692] unify this after we unify the
// CREATE TABLE syntax for hive serde and data source table.
- val stmt = if (DDLUtils.isDatasourceTable(tableMetadata)) {
- showCreateDataSourceTable(tableMetadata)
+ val metadata = if (DDLUtils.isDatasourceTable(tableMetadata)) {
+ tableMetadata
} else {
- showCreateHiveTable(tableMetadata)
+ // For a Hive serde table, we try to convert it to Spark DDL.
+ if (tableMetadata.unsupportedFeatures.nonEmpty) {
+ throw new AnalysisException(
+ "Failed to execute SHOW CREATE TABLE against table " +
+ s"${tableMetadata.identifier}, which is created by Hive and uses
the " +
+ "following unsupported feature(s)\n" +
+ tableMetadata.unsupportedFeatures.map(" - " + _).mkString("\n")
+ )
+ }
+
+ if (tableMetadata.tableType == VIEW) {
+ throw new AnalysisException("Hive view isn't supported by SHOW
CREATE TABLE")
+ }
+
+ if
("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional",
"false"))) {
+ throw new AnalysisException(
+ "SHOW CREATE TABLE doesn't support transactional Hive table")
+ }
+
+ convertTableMetadata(tableMetadata)
}
+ val stmt = showCreateDataSourceTable(metadata)
+
Seq(Row(stmt))
}
}
+ private def convertTableMetadata(tableMetadata: CatalogTable): CatalogTable
= {
+ val hiveSerde = HiveSerDe(
+ serde = tableMetadata.storage.serde,
+ inputFormat = tableMetadata.storage.inputFormat,
+ outputFormat = tableMetadata.storage.outputFormat)
+
+ // Looking for Spark data source that maps to to the Hive serde.
+ // TODO: some Hive fileformat + row serde might be mapped to Spark data
source, e.g. CSV.
+ val source = HiveSerDe.serdeToSource(hiveSerde)
+ if (source.isEmpty) {
+ val builder = StringBuilder.newBuilder
+ hiveSerde.serde.foreach { serde =>
+ builder ++= s" SERDE: $serde"
+ }
+ hiveSerde.inputFormat.foreach { format =>
+ builder ++= s" INPUTFORMAT: $format"
+ }
+ hiveSerde.outputFormat.foreach { format =>
+ builder ++= s" OUTPUTFORMAT: $format"
+ }
+ throw new AnalysisException(
+ "Failed to execute SHOW CREATE TABLE AS SPARK against table " +
Review comment:
Oops. Thanks for finding this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
