Ngone51 commented on a change in pull request #27693: [SPARK-30947][CORE] Don't
log accelerate resources when it's empty
URL: https://github.com/apache/spark/pull/27693#discussion_r383899990
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
##########
@@ -362,8 +362,9 @@ private[spark] object ResourceUtils extends Logging {
def logResourceInfo(componentName: String, resources: Map[String,
ResourceInformation])
: Unit = {
+ if (resources.isEmpty) return
logInfo("==============================================================")
- logInfo(s"Resources for $componentName:\n${resources.mkString("\n")}")
+ logInfo(s"Accelerate Resources for
$componentName:\n${resources.mkString("\n")}")
Review comment:
@tgravescs Do we always log all the resources after introducing
`ResourceProfile`? If so, I think we may could remove `logResourceInfo`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
