cloud-fan commented on a change in pull request #28043: [SPARK-31280][SQL]
Perform propagating empty relation after RewritePredicateSubquery
URL: https://github.com/apache/spark/pull/28043#discussion_r399059347
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3494,14 +3494,27 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
Seq(Row(Map[Int, Int]()), Row(Map(1 -> 2))))
}
- test("SPARK-31242: clone SparkSession should respect
sessionInitWithConfigDefaults") {
- // Note, only the conf explicitly set in SparkConf(e.g. in
SharedSparkSessionBase) would cause
- // problem before the fix.
- withSQLConf(SQLConf.CODEGEN_FALLBACK.key -> "true") {
- val cloned = spark.cloneSession()
- SparkSession.setActiveSession(cloned)
- assert(SQLConf.get.getConf(SQLConf.CODEGEN_FALLBACK) === true)
- }
+ test("Perform propagating empty relation after RewritePredicateSubquery") {
Review comment:
can we add a UT in `RewriteSubquerySuite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
