dongjoon-hyun commented on a change in pull request #28895:
URL: https://github.com/apache/spark/pull/28895#discussion_r446476096
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -335,23 +335,6 @@ private[spark] abstract class MapOutputTracker(conf:
SparkConf) extends Logging
* tuples describing the shuffle blocks that are stored at that
block manager.
*/
def getMapSizesByExecutorId(
- shuffleId: Int,
- startPartition: Int,
- endPartition: Int)
- : Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])]
-
- /**
- * Called from executors to get the server URIs and output sizes for each
shuffle block that
- * needs to be read from a given range of map output partitions
(startPartition is included but
- * endPartition is excluded from the range) and is produced by
- * a range of mappers (startMapIndex, endMapIndex, startMapIndex is included
and
- * the endMapIndex is excluded).
Review comment:
Hi, @Ngone51 . This should be the function description of the unified
`getMapSizesByExecutorId`. Did I understand correctly? Or, could you add a
comment about `startMapIndex` and `endMapIndex` and about when we don't care
about that because of `actualEndMapIndex` (you don't need to mention this
variable name specifically).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
