srowen commented on a change in pull request #29088:
URL: https://github.com/apache/spark/pull/29088#discussion_r454436084



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala
##########
@@ -39,6 +39,10 @@ class CsvOutputWriter(
 
   private val gen = new UnivocityGenerator(dataSchema, writer, params)
 
+  if (params.bom) {
+    writer.write(0xFEFF)

Review comment:
       Yes, this is the wrong BOM. It may help your case but is going to break 
others - even adding the BOM might break things. I think you should tell Excel 
that you need _UTF-16_ when reading the file. That's what you're 'fixing'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to