HyukjinKwon commented on a change in pull request #29088:
URL: https://github.com/apache/spark/pull/29088#discussion_r454812272



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
##########
@@ -2353,6 +2354,43 @@ abstract class CSVSuite extends QueryTest with 
SharedSparkSession with TestCsvDa
       assert(df.schema.last == StructField("col_mixed_types", StringType, 
true))
     }
   }
+
+  test("Support write BOM to file before writing data if encoded by UTF-8 
charset") {
+    // scalastyle:off nonascii
+    val chinese = "我爱中文"
+    val korean = "나는 한국인을 좋아한다"

Review comment:
       Oh, @wangyum BTW, do you mean "I like Korean" but Korean as a language? 
If that's the case, I think you should write like "나는 한국어를 좋아한다". The current 
one is more like I like Korean people.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to