tgravescs commented on a change in pull request #29331:
URL: https://github.com/apache/spark/pull/29331#discussion_r467948800
##########
File path: core/src/test/scala/org/apache/spark/DistributedSuite.scala
##########
@@ -206,7 +206,8 @@ class DistributedSuite extends SparkFunSuite with Matchers
with LocalSparkContex
"caching on disk" -> StorageLevel.DISK_ONLY,
"caching in memory, replicated" -> StorageLevel.MEMORY_ONLY_2,
"caching in memory, serialized, replicated" ->
StorageLevel.MEMORY_ONLY_SER_2,
- "caching on disk, replicated" -> StorageLevel.DISK_ONLY_2,
+ "caching on disk, replicated 2" -> StorageLevel.DISK_ONLY_2,
+ "caching on disk, replicated 3" -> StorageLevel.DISK_ONLY_3,
Review comment:
so what happen if there aren't 3 executors? do we have a test that needs
updating?
##########
File path: docs/rdd-programming-guide.md
##########
@@ -1256,7 +1256,7 @@ storage levels is:
**Note:** *In Python, stored objects will always be serialized with the
[Pickle](https://docs.python.org/2/library/pickle.html) library,
so it does not matter whether you choose a serialized level. The available
storage levels in Python include `MEMORY_ONLY`, `MEMORY_ONLY_2`,
-`MEMORY_AND_DISK`, `MEMORY_AND_DISK_2`, `DISK_ONLY`, and `DISK_ONLY_2`.*
+`MEMORY_AND_DISK`, `MEMORY_AND_DISK_2`, `DISK_ONLY`, `DISK_ONLY_2`, and
`DISK_ONLY_3`.*
Review comment:
it looks like we need to update the table above as well?
it might be nice to say what happens if you specify a level > 1 but you
don't have that many executors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
