cloud-fan commented on a change in pull request #30442:
URL: https://github.com/apache/spark/pull/30442#discussion_r528559834
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -364,6 +364,15 @@ object DateTimeUtils {
}
}
+ def stringToTimestamp(s: UTF8String, timeZoneId: ZoneId, ansiEnabled:
Boolean): Option[Long] = {
Review comment:
It's better to add a `stringToTimestampAnsi` method. Non-ansi code path
should call the original `stringToTimestamp` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
