viirya commented on a change in pull request #30522:
URL: https://github.com/apache/spark/pull/30522#discussion_r532088667



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -710,6 +710,11 @@ class SparkContext(config: SparkConf) extends Logging {
     }
   }
 
+  /** Set spark conf */
+  def setSparkConf(sparkConf: SparkConf): Unit = {

Review comment:
       Agree with @HyukjinKwon. Static SQL configs are static and immutable. 
Forcefully modifying the configs could cause unexpected behavior.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to