Ngone51 commented on a change in pull request #30480:
URL: https://github.com/apache/spark/pull/30480#discussion_r534968149
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -524,10 +669,37 @@ private[spark] class MapOutputTrackerMaster(
}
}
+ def registerMergeResult(shuffleId: Int, reduceId: Int, status: MergeStatus) {
+ shuffleStatuses(shuffleId).addMergeResult(reduceId, status)
+ }
+
+ def registerMergeResults(shuffleId: Int, statuses: Seq[(Int, MergeStatus)]):
Unit = {
+ statuses.foreach {
+ case (reduceId, status) => registerMergeResult(shuffleId, reduceId,
status)
+ }
+ }
+
+ def unregisterMergeResult(shuffleId: Int, reduceId: Int, bmAddress:
BlockManagerId) {
Review comment:
Thanks for clarify. But I think we usually don't add functions when
they're not necessary. We can always add them back when we needed in future
improvement. For now, I think they only introduce unnecessary review work. So
I'd suggest to remove it first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
