linhongliu-db commented on a change in pull request #30662:
URL: https://github.com/apache/spark/pull/30662#discussion_r539362189
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -114,7 +114,8 @@ case class AnalysisContext(
nestedViewDepth: Int = 0,
maxNestedViewDepth: Int = -1,
relationCache: mutable.Map[Seq[String], LogicalPlan] = mutable.Map.empty,
- referredTempViewNames: Seq[Seq[String]] = Seq.empty)
+ referredTempViewNames: Seq[Seq[String]] = Seq.empty,
+ isTempView: Boolean = false)
Review comment:
if we change the type to referredTempFuncNames: Option[Seq[String]],
then it can replace `isTempView`. Because Seq.empty can be permanent view or
temp view refers non temp functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
