viirya commented on a change in pull request #30827:
URL: https://github.com/apache/spark/pull/30827#discussion_r548915137
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreCoordinator.scala
##########
@@ -122,13 +125,20 @@ private class StateStoreCoordinator(override val rpcEnv:
RpcEnv)
extends ThreadSafeRpcEndpoint with Logging {
private val instances = new mutable.HashMap[StateStoreProviderId,
ExecutorCacheTaskLocation]
- override def receive: PartialFunction[Any, Unit] = {
- case ReportActiveInstance(id, host, executorId) =>
+ override def receiveAndReply(context: RpcCallContext): PartialFunction[Any,
Unit] = {
+ case ReportActiveInstance(id, host, executorId, otherProviderIds) =>
Review comment:
Okay. I added a few comment and change the parameter name.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreCoordinator.scala
##########
@@ -122,13 +125,20 @@ private class StateStoreCoordinator(override val rpcEnv:
RpcEnv)
extends ThreadSafeRpcEndpoint with Logging {
private val instances = new mutable.HashMap[StateStoreProviderId,
ExecutorCacheTaskLocation]
- override def receive: PartialFunction[Any, Unit] = {
- case ReportActiveInstance(id, host, executorId) =>
+ override def receiveAndReply(context: RpcCallContext): PartialFunction[Any,
Unit] = {
+ case ReportActiveInstance(id, host, executorId, otherProviderIds) =>
Review comment:
Okay. I added a few comment and changed the parameter name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
