xkrogen commented on a change in pull request #30701:
URL: https://github.com/apache/spark/pull/30701#discussion_r558532319
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -112,11 +112,24 @@ private[hive] object IsolatedClientLoader extends Logging
{
hadoopVersion: String,
ivyPath: Option[String],
remoteRepos: String): Seq[URL] = {
+ val hadoopJarNames = if (hadoopVersion.startsWith("3")) {
Review comment:
Yah I think (2) is my primary concern. We support building against a
custom version using `-Dhadoop.version`, but right now it will break if you use
`-Phadoop-3 -Dhadoop.version=3.1.0`. This one I believe you can at least work
around by changing the `-Dhadoop-client-{runtime,api,minicluster}.artifact`
properties, but here there's no way to work around it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
