cloud-fan commented on a change in pull request #31273:
URL: https://github.com/apache/spark/pull/31273#discussion_r581592514
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
##########
@@ -59,6 +59,28 @@ trait AnalysisTest extends PlanTest {
}
}
+ protected def checkAnalysisWithTransform(
+ inputPlan: LogicalPlan,
+ expectedPlan: LogicalPlan,
+ caseSensitive: Boolean = true)(transform: LogicalPlan => LogicalPlan):
Unit = {
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> caseSensitive.toString) {
+ val analyzer = getAnalyzer
+ val actualPlan = analyzer.executeAndCheck(inputPlan, new
QueryPlanningTracker)
+ comparePlans(transform(actualPlan), expectedPlan)
+ }
+ }
+
+ protected def checkAnalysisWithoutViewWrapper(
+ inputPlan: LogicalPlan,
+ expectedPlan: LogicalPlan,
+ caseSensitive: Boolean = true): Unit = {
+ checkAnalysisWithTransform(inputPlan, expectedPlan, caseSensitive) { plan
=>
Review comment:
shall we inline `checkAnalysisWithTransform` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
