yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584465609



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
     val warehousePath = if (hiveWarehouseDir != null && 
sparkWarehouseOption.isEmpty) {
       // If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is 
not set,
       // we will respect the value of hive.metastore.warehouse.dir.
-      sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
       logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is 
set. Setting" +

Review comment:
       These log messages look not very useful to me personally before or after 
this change. But we do not vary the logging logic with this change, I am not 
sure if there is anyone who relies on these outputs




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to