cloud-fan commented on a change in pull request #34474:
URL: https://github.com/apache/spark/pull/34474#discussion_r742694720
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -621,6 +621,17 @@ abstract class TypedImperativeAggregate[T] extends
ImperativeAggregate {
buffer(mutableAggBufferOffset) = serialize(getBufferObject(buffer))
}
+ /**
+ * In-place replaces SparkSQL internally supported underlying storage format
(BinaryType),
+ * with the aggregation buffer object stored at buffer's index
`mutableAggBufferOffset`.
Review comment:
`stored at buffer's index mutableAggBufferOffset` describes the binary,
should be put before `with the aggregation buffer object ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
