HyukjinKwon commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r744620552



##########
File path: python/pyspark/mllib/stat/distribution.py
##########
@@ -15,12 +15,14 @@
 # limitations under the License.
 #
 
-from collections import namedtuple
-
 __all__ = ['MultivariateGaussian']
 
+from typing import NamedTuple
+
+from pyspark.mllib.linalg import Matrix, Vector
+
 
-class MultivariateGaussian(namedtuple('MultivariateGaussian', ['mu', 
'sigma'])):
+class MultivariateGaussian(NamedTuple):

Review comment:
       Hm, is't it a breaking change? Previously it inherited an actual named 
tuple that works like named tuple. Now it inherits the typing class of 
`NamedTuple`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to