dchvn commented on a change in pull request #34435:
URL: https://github.com/apache/spark/pull/34435#discussion_r747950440
##########
File path: python/pyspark/statcounter.py
##########
@@ -19,18 +19,19 @@
import copy
import math
+from typing import cast, Dict, Iterable, Optional, Union
try:
from numpy import maximum, minimum, sqrt
except ImportError:
- maximum = max
- minimum = min
- sqrt = math.sqrt
+ maximum = max # type: ignore
+ minimum = min # type: ignore
+ sqrt = math.sqrt # type: ignore
Review comment:
@zero323 , can you review it again? Many thanks 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
