wangshengjie123 commented on a change in pull request #34834:
URL: https://github.com/apache/spark/pull/34834#discussion_r767383103
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -954,7 +954,7 @@ private[spark] class TaskSetManager(
taskSetExcludelistHelperOpt.foreach(_.updateExcludedForFailedTask(
info.host, info.executorId, index, failureReason))
numFailures(index) += 1
- if (numFailures(index) >= maxTaskFailures) {
+ if (numFailures(index) >= maxTaskFailures && !successful(index)) {
Review comment:
> I don't see the potential issues with this change. So I am personally
ok with it. Might be better to add a log for the case.
Thanks for review the pr. I will add some log later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
