cloud-fan commented on a change in pull request #35202:
URL: https://github.com/apache/spark/pull/35202#discussion_r789482501
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -1235,7 +1235,7 @@ class HiveDDLSuite
if (tableExists && !cascade) {
assertAnalysisError(
sqlDropDatabase,
- s"Cannot drop a non-empty database: $dbName.")
+ s"Cannot drop a non-empty namespace: $dbName.")
Review comment:
My concern is that this may confuse traditional SQL users, as
`namespace` is a new concept to them.
I think we need to allow catalog implementations to customize the alias of
namespace, such as database, schema. We can add a new API to `CatalogPlugin`
```
default String namespaceAlias() { return "namespace"; };
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
