mcdull-zhang commented on a change in pull request #35878:
URL: https://github.com/apache/spark/pull/35878#discussion_r828774014
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -65,7 +65,7 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper {
case fs: HadoopFsRelation =>
val partitionColumns = AttributeSet(
l.resolve(fs.partitionSchema,
fs.sparkSession.sessionState.analyzer.resolver))
- if (resExp.references.subsetOf(partitionColumns)) {
+ if (!resExp.references.isEmpty &&
resExp.references.subsetOf(partitionColumns)) {
Review comment:
HadoopFsRelation, HiveTableRelation, DataSourceV2ScanRelation all need
this check, and now I filter the literal at the beginning.
Is such code reasonable? Or should I handle it in
findExpressionAndTrackLineageDown? Or should it be handled in three case
statements?
Thank you for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
