cloud-fan commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r833865770
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -999,13 +1000,27 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
}
public UTF8String[] split(UTF8String pattern, int limit) {
+ return split(pattern.toString(), limit);
+ }
+
+ public UTF8String[] splitSQL(UTF8String delimiter, int limit) {
+ // if delimiter is empty string, skip the regex based splitting directly
as regex
+ // treats empty string as matching anything, thus use the input directly.
+ if (delimiter.numBytes() == 0) {
+ return new UTF8String[]{this};
+ } else {
+ return split(Pattern.quote(delimiter.toString()), limit);
Review comment:
Can we add a bit more code comments to explain the quoting logic? This
is the major difference from the normal split function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
