gengliangwang commented on code in PR #36122:
URL: https://github.com/apache/spark/pull/36122#discussion_r865527403
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1440,6 +1440,75 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
}
+ test("SPARK-38838 INSERT INTO with defaults set by ALTER TABLE ALTER COLUMN:
positive tests") {
+ withTable("t") {
+ sql("create table t(i boolean, s string, k bigint) using parquet")
+ // The default value for the DEFAULT keyword is the NULL literal.
+ sql("insert into t values(true, default, default)")
+ // There is a complex expression in the default value.
+ sql("alter table t alter column s set default concat('abc', 'def')")
+ sql("insert into t values(true, default, default)")
+ // The default value parses correctly and the provided value type is
different but coercible.
+ sql("alter table t alter column k set default 42")
+ sql("insert into t values(true, default, default)")
+ // After dropping the default, inserting more values should add NULLs.
+ sql("alter table t alter column k drop default")
+ sql("insert into t values(true, default, default)")
+ checkAnswer(spark.table("t"),
+ Seq(
+ Row(true, null, null),
+ Row(true, "abcdef", null),
+ Row(true, "abcdef", 42),
+ Row(true, "abcdef", null)
+ ))
+ }
+ }
+
+ test("SPARK-38338 INSERT INTO with defaults set by ALTER TABLE ALTER COLUMN:
negative tests") {
+ object Errors {
+ val COMMON_SUBSTRING = " has a DEFAULT value"
+ val BAD_SUBQUERY =
+ "cannot evaluate expression CAST(scalarsubquery() AS BIGINT) in inline
table definition"
+ }
+ val createTable = "create table t(i boolean, s bigint) using parquet"
+ val insertDefaults = "insert into t values (default, default)"
+ withTable("t") {
+ sql(createTable)
+ // The default value fails to analyze.
+ sql("alter table t alter column s set default badvalue")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.COMMON_SUBSTRING))
+ // The default value analyzes to a table not in the catalog.
+ sql("alter table t alter column s set default (select min(x) from
badtable)")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.COMMON_SUBSTRING))
+ // The default value has an explicit alias. It fails to evaluate when
inlined into the VALUES
+ // list at the INSERT INTO time.
+ sql("alter table t alter column s set default (select 42 as alias)")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.BAD_SUBQUERY))
+ // The default value parses but the type is not coercible.
+ sql("alter table t alter column s set default false")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains("provided a value of incompatible type"))
+ // The default value is disabled per configuration.
+ withSQLConf(SQLConf.ENABLE_DEFAULT_COLUMNS.key -> "false") {
+ sql("alter table t alter column s set default 41 + 1")
Review Comment:
It seems this is working?
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1440,6 +1440,75 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
}
+ test("SPARK-38838 INSERT INTO with defaults set by ALTER TABLE ALTER COLUMN:
positive tests") {
+ withTable("t") {
+ sql("create table t(i boolean, s string, k bigint) using parquet")
+ // The default value for the DEFAULT keyword is the NULL literal.
+ sql("insert into t values(true, default, default)")
+ // There is a complex expression in the default value.
+ sql("alter table t alter column s set default concat('abc', 'def')")
+ sql("insert into t values(true, default, default)")
+ // The default value parses correctly and the provided value type is
different but coercible.
+ sql("alter table t alter column k set default 42")
+ sql("insert into t values(true, default, default)")
+ // After dropping the default, inserting more values should add NULLs.
+ sql("alter table t alter column k drop default")
+ sql("insert into t values(true, default, default)")
+ checkAnswer(spark.table("t"),
+ Seq(
+ Row(true, null, null),
+ Row(true, "abcdef", null),
+ Row(true, "abcdef", 42),
+ Row(true, "abcdef", null)
+ ))
+ }
+ }
+
+ test("SPARK-38338 INSERT INTO with defaults set by ALTER TABLE ALTER COLUMN:
negative tests") {
+ object Errors {
+ val COMMON_SUBSTRING = " has a DEFAULT value"
+ val BAD_SUBQUERY =
+ "cannot evaluate expression CAST(scalarsubquery() AS BIGINT) in inline
table definition"
+ }
+ val createTable = "create table t(i boolean, s bigint) using parquet"
+ val insertDefaults = "insert into t values (default, default)"
+ withTable("t") {
+ sql(createTable)
+ // The default value fails to analyze.
+ sql("alter table t alter column s set default badvalue")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.COMMON_SUBSTRING))
+ // The default value analyzes to a table not in the catalog.
+ sql("alter table t alter column s set default (select min(x) from
badtable)")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.COMMON_SUBSTRING))
+ // The default value has an explicit alias. It fails to evaluate when
inlined into the VALUES
+ // list at the INSERT INTO time.
+ sql("alter table t alter column s set default (select 42 as alias)")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains(Errors.BAD_SUBQUERY))
+ // The default value parses but the type is not coercible.
+ sql("alter table t alter column s set default false")
+ assert(intercept[AnalysisException] {
+ sql(insertDefaults)
+ }.getMessage.contains("provided a value of incompatible type"))
+ // The default value is disabled per configuration.
+ withSQLConf(SQLConf.ENABLE_DEFAULT_COLUMNS.key -> "false") {
+ sql("alter table t alter column s set default 41 + 1")
Review Comment:
It seems this is working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
