peter-toth commented on code in PR #36027:
URL: https://github.com/apache/spark/pull/36027#discussion_r966850639
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -1095,7 +1095,11 @@ private[hive] object HiveClientImpl extends Logging {
table.bucketSpec match {
case Some(bucketSpec) if !HiveExternalCatalog.isDatasourceTable(table) =>
hiveTable.setNumBuckets(bucketSpec.numBuckets)
- hiveTable.setBucketCols(bucketSpec.bucketColumnNames.toList.asJava)
Review Comment:
Hmm, that's what I explained in
https://github.com/apache/spark/pull/36027#discussion_r966199347 that simply
lowercasing only bucketspec doesn't work. Because when the test creates the
table and calls `toHiveTable()` first, it is called with uppercase column and
bucketspec from the provided query text. If we lowecase bucketspec only then
the failure will come during create table.
As Hive expects `setFields()` and `setBucketCols()` to use the same letter
case we could lowecase both or use my PR to sync bucketspec to columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
