gengliangwang commented on code in PR #38567:
URL: https://github.com/apache/spark/pull/38567#discussion_r1028629241
##########
core/src/main/scala/org/apache/spark/status/KVUtils.scala:
##########
@@ -80,6 +89,44 @@ private[spark] object KVUtils extends Logging {
db
}
+ def createKVStore(
+ storePath: Option[File],
+ diskBackend: HybridStoreDiskBackend.Value,
+ conf: SparkConf): KVStore = {
+ storePath.map { path =>
+ val dir = diskBackend match {
+ case LEVELDB => "listing.ldb"
+ case ROCKSDB => "listing.rdb"
+ }
+
+ val dbPath = Files.createDirectories(new File(path,
dir).toPath()).toFile()
+ Utils.chmod700(dbPath)
+
+
+ val metadata = FsHistoryProviderMetadata(
+ FsHistoryProvider.CURRENT_LISTING_VERSION,
+ AppStatusStore.CURRENT_VERSION,
+ conf.get(History.HISTORY_LOG_DIR))
+
+ try {
+ open(dbPath, metadata, conf, Some(diskBackend))
+ } catch {
Review Comment:
@tgravescs If there is exception from RocksDB, it will delete the target
directory and open the KV store again. Otherwise if the error is not from
RocksDB, it will fall back to the in-memory store.
It follows the same logic in SHS here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
