toujours33 commented on code in PR #38711:
URL: https://github.com/apache/spark/pull/38711#discussion_r1034404863
##########
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala:
##########
@@ -775,16 +779,14 @@ private[spark] class ExecutorAllocationManager(
}
}
if (taskEnd.taskInfo.speculative) {
- stageAttemptToSpeculativeTaskIndices.get(stageAttempt).foreach
{_.remove{taskIndex}}
- // If the previous task attempt succeeded first and it was the last
task in a stage,
- // the stage may have been removed before handing this speculative
TaskEnd event.
- if (stageAttemptToNumSpeculativeTasks.contains(stageAttempt)) {
- stageAttemptToNumSpeculativeTasks(stageAttempt) -= 1
- }
+
stageAttemptToSpeculativeTaskIndices.get(stageAttempt).foreach(_.remove(taskIndex))
}
taskEnd.reason match {
- case Success | _: TaskKilled =>
+ case Success =>
+ // remove speculative task for task finished.
Review Comment:
Good idea!
##########
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala:
##########
@@ -810,9 +812,10 @@ private[spark] class ExecutorAllocationManager(
val stageId = speculativeTask.stageId
val stageAttemptId = speculativeTask.stageAttemptId
val stageAttempt = StageAttempt(stageId, stageAttemptId)
+ val taskIndex = speculativeTask.taskIndex
allocationManager.synchronized {
- stageAttemptToNumSpeculativeTasks(stageAttempt) =
- stageAttemptToNumSpeculativeTasks.getOrElse(stageAttempt, 0) + 1
+ stageAttemptToUnsubmittedSpeculativeTasks.getOrElseUpdate(stageAttempt,
Review Comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
