zwangsheng commented on code in PR #38202:
URL: https://github.com/apache/spark/pull/38202#discussion_r1039131007
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala:
##########
@@ -50,6 +50,8 @@ private[spark] class DriverServiceFeatureStep(
s"$shorterServiceName as the driver service's name.")
shorterServiceName
}
+ // expose driver service name
+ kubernetesConf.sparkConf.set(RESOLVED_SPARK_DRIVER_SVC_NAME,
resolvedServiceName)
Review Comment:
I agree with you that Apache Spark haven't tried to break this read-only
rule elsewhere for `kubernetesConf.sparkConf`, so maybe we can try adding an
additional variable to kubernetesConf for contextual passing.
I will make changes to the logic inside the PR to comply with the
`kubernetesConf.sparkConf` read-only principle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
