cloud-fan commented on code in PR #38908:
URL: https://github.com/apache/spark/pull/38908#discussion_r1039153768
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -137,7 +137,13 @@ def isEmpty(self) -> bool:
return len(self.take(1)) == 0
def select(self, *cols: "ColumnOrName") -> "DataFrame":
- return DataFrame.withPlan(plan.Project(self._plan, *cols),
session=self._session)
+ sql_expr = []
+ for element in cols:
+ if isinstance(element, str):
+ sql_expr.append(sql_expression(element))
Review Comment:
I think the string here must be column name, otherwise people should call
`selectExpr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
