HeartSaVioR commented on code in PR #39069:
URL: https://github.com/apache/spark/pull/39069#discussion_r1049322889
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -560,21 +560,35 @@ case class RocksDBConf(
object RocksDBConf {
/** Common prefix of all confs in SQLConf that affects RocksDB */
- val ROCKSDB_CONF_NAME_PREFIX = "spark.sql.streaming.stateStore.rocksdb"
+ val ROCKSDB_SQL_CONF_NAME_PREFIX = "spark.sql.streaming.stateStore.rocksdb"
private case class ConfEntry(name: String, default: String) {
Review Comment:
nit: abstract class or trait. extending case class is a bad practice for
Scala.
EDIT: It's not just a bad practice. It's disallowed.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -560,21 +560,35 @@ case class RocksDBConf(
object RocksDBConf {
/** Common prefix of all confs in SQLConf that affects RocksDB */
- val ROCKSDB_CONF_NAME_PREFIX = "spark.sql.streaming.stateStore.rocksdb"
+ val ROCKSDB_SQL_CONF_NAME_PREFIX = "spark.sql.streaming.stateStore.rocksdb"
private case class ConfEntry(name: String, default: String) {
Review Comment:
abstract class or trait. extending case class is a bad practice for Scala.
EDIT: It's not just a bad practice. It's disallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
