HeartSaVioR commented on code in PR #39647:
URL: https://github.com/apache/spark/pull/39647#discussion_r1080686668
##########
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala:
##########
@@ -51,6 +51,7 @@ import org.apache.spark.streaming.scheduler.StreamingListener
* respectively. `context.awaitTermination()` allows the current thread to
wait for the
* termination of a context by `stop()` or by an exception.
*/
+@deprecated
Review Comment:
ditto
##########
streaming/src/test/java/org/apache/spark/streaming/LocalJavaStreamingContext.java:
##########
@@ -22,6 +22,8 @@
import org.junit.After;
import org.junit.Before;
+@SuppressWarnings( "deprecation" )
+
Review Comment:
nit: remove empty line
##########
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala:
##########
@@ -61,6 +61,7 @@ import org.apache.spark.util.{CallSite, ShutdownHookManager,
ThreadUtils, Utils}
* `context.awaitTermination()` allows the current thread to wait for the
termination
* of the context by `stop()` or by an exception.
*/
+@deprecated
Review Comment:
We should probably leave a short note to promote moving to Structured
Streaming.
> This is deprecated as of Spark 3.4.0. There are no longer updates to
DStream and it’s a legacy project. There is a newer and easier to use streaming
engine in Spark called Structured Streaming. You should use Spark Structured
Streaming for your streaming applications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
