grundprinzip commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1082117732
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -217,6 +218,28 @@ message Expression {
bool is_user_defined_function = 4;
}
+ message ScalarInlineUserDefinedFunction {
+ // (Required) Name of the user-defined function.
+ string function_name = 1;
+ // (Required) Indicate if the user-defined function is deterministic.
+ bool deterministic = 2;
+ // (Optional) Function arguments. Empty arguments are allowed.
+ repeated Expression arguments = 3;
+ // (Required) Indicate the function type of the user-defined function.
+ oneof function {
+ PythonUDF python_udf = 5;
Review Comment:
No this is a bug. It's fine to make it id 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
